Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OUDS] Css: drop deprecated Boosted variables and change deprecated comments #2638

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

julien-deramond
Copy link
Contributor

Related issues

Listed in #2589

Description

This PR handles the "deprecate" comments in JavaScript and Sass files.

The rules are the following:

  • If the deprecation comment comes from Bootstrap, keep it and include the word "Bootstrap" in it
  • If the deprecation comment comes from Boosted and relies on Bootstrap values, change it to OUDS Web, and keep the Boosted previous values for Boosted projects migrating to OUDS Web
  • If the deprecation comment comes from Boosted only, the corresponding variable(s) can be removed from the framework

All removed Sass variables are listed in the Boosted migration guide.

Types of change

  • Refactoring (non-breaking change)

@julien-deramond julien-deramond added docs Improvements or additions to documentation css labels Jul 22, 2024
@julien-deramond julien-deramond added this to the OUDS milestone Jul 22, 2024
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 29c5986
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/669f5c6310ab32000874716c
😎 Deploy Preview https://deploy-preview-2638--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond changed the title css: drop deprecated Boosted variables and change deprecated comments [OUDS] Css: drop deprecated Boosted variables and change deprecated comments Jul 22, 2024
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it lacks a bit of consistency between all the deprecating messages. I think it would be great to have the rules for those messages stored in the description and not only the rules for search & replace. For instance, we have deprecated in Bootstrap * but can we use it in OUDS since we have deprecation messages like deprecated in OUDS? Maybe a clear message like: Not to be used in OUDS because it is deprecated in Bootstrap v* or something similar everywhere would be safer. I also think that we could write the rules and keep the rewording when we will reintroduce things little by little.

One small change is needed and we could launch the PR imo.

site/content/docs/0.0/migration-from-boosted.md Outdated Show resolved Hide resolved
@julien-deramond julien-deramond merged commit 8b7d1c8 into ouds/main Jul 23, 2024
12 checks passed
@julien-deramond julien-deramond deleted the ouds/main-drop-deprecate-sass-variables branch July 23, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css docs Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants